Skip to content

fix: filter GET /api/transactions by authenticated user_id - #61

Closed
kutluhaneth46 wants to merge 1 commit into
circlefin:masterfrom
kutluhaneth46:fix/filter-transactions-by-user-id
Closed

fix: filter GET /api/transactions by authenticated user_id#61
kutluhaneth46 wants to merge 1 commit into
circlefin:masterfrom
kutluhaneth46:fix/filter-transactions-by-user-id

Conversation

@kutluhaneth46

Copy link
Copy Markdown

Summary

  • Add .eq("user_id", user.id) to the GET /api/transactions Supabase query so authenticated users only receive their own rows
  • Closes the data-exposure gap where any logged-in user could list all transaction_type = 'USER' records

Related: open PR #31 covers overlapping user_id filtering work; this PR is a focused fix on the list endpoint against current upstream/master.

Test plan

  • As user A, create/list transactions and confirm only A's rows are returned
  • As user B, call GET /api/transactions and confirm A's transactions are not returned
  • Unauthenticated request still returns 401

@kutluhaneth46
kutluhaneth46 force-pushed the fix/filter-transactions-by-user-id branch from 8ce1adc to ac9ffb4 Compare September 6, 2026 14:16
@kutluhaneth46

Copy link
Copy Markdown
Author

Closing this to reduce open-PR noise and focus my remaining reviews on a smaller set of higher-signal threads.

Happy to reopen later if maintainers still want this change — thanks for your time.

1 similar comment
@kutluhaneth46

Copy link
Copy Markdown
Author

Closing this to reduce open-PR noise and focus my remaining reviews on a smaller set of higher-signal threads.

Happy to reopen later if maintainers still want this change — thanks for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant